万宝锐旗直招-ethan-frontend #1841
Open
万宝锐旗直招-ethan-frontend #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weikaixiong
force-pushed
the
master
branch
2 times, most recently
from
ae28049 to
7a3c9e9
Compare
YuHanLi777
reviewed
Apr 24, 2023
| } | ||
| } | ||
| onMouseLeave={()=>{ | ||
| setAuto(true) |
There was a problem hiding this comment.
我理解这个地方可能设计的有些问题，autoplay 本质上是决定轮播图是不是自动播放的，如果这样设计的话，即使我设置了 false，点击之后又变成自动播放了
|
可以的话补充一些测试代码吧 |
YuHanLi777
reviewed
Apr 24, 2023
| } | ||
|
|
||
| const Carousel: FC<CarouselProps> = ({ items, delay = 3000, autoPlay = true}) => { | ||
| const [active, setActive] = useState<number>(0) |
YuHanLi777
reviewed
Apr 24, 2023
|
|
||
| const Carousel: FC<CarouselProps> = ({ items, delay = 3000, autoPlay = true}) => { | ||
| const [active, setActive] = useState<number>(0) | ||
| const [auto,setAuto] = useState<boolean>(autoPlay) |
YuHanLi777
reviewed
Apr 24, 2023
| const [auto,setAuto] = useState<boolean>(autoPlay) | ||
|
|
||
| useEffect(() => { | ||
| if (active >= items.length) { |
There was a problem hiding this comment.
这种边界情况是在防止什么 case, items 的变动吗，我理解如果是这样不应该是这样来处理
YuHanLi777
reviewed
Apr 24, 2023
| return | ||
| } | ||
| const timer = setTimeout(() => setActive((active + 1) % items.length), delay) | ||
| if(!auto){ |
There was a problem hiding this comment.
在这里用 auto 判断属于为了交互强行写逻辑了，auto 不纯粹且和交互严重耦合
YuHanLi777
reviewed
Apr 24, 2023
| }} | ||
| > | ||
| <div className="text-content" style={{ color: item.color }}> | ||
| <h2 className="title">{item.title?.join('\r\n')}</h2> |
There was a problem hiding this comment.
item.title 不存在还要展示 这个 h2 吗
There was a problem hiding this comment.
是的 应该{item.title &&
{item.title?.join('\r\n')}
}
YuHanLi777
reviewed
Apr 24, 2023
| {items.map((item, idx) => ( | ||
| <li | ||
| key={item.id} | ||
| className={`${idx === active ? 'indicator active' : 'indicator'}`} |
There was a problem hiding this comment.
indicator ${idx === active ? 'active' : '‘}
There was a problem hiding this comment.
这种模板字符串的话 indicator 后面会多一个空格
There was a problem hiding this comment.
indicator${idx === active ? ' active' : '‘}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.